refactor: improve /describe requests for schema objects #1353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raubzeug
force-pushed
the
1246-performance
branch
from
ca3ab2c to
84bc666
Compare
Raubzeug
force-pushed
the
1246-performance
branch
from
84bc666 to
b9465d2
Compare
ValeraS
requested changes
Sep 26, 2024
ValeraS
requested changes
Sep 26, 2024
| return {currentDescribe: emptyObject, ...props}; | ||
| } | ||
|
|
||
| const mergedData = Object.values(currentData).flat(); |
Collaborator
There was a problem hiding this comment.
This looks cryptic, I suggest writing it more clearly
Suggested change
| const mergedData = Object.values(currentData).flat(); | |
| const mergedData = [currentData.data, ...currentData.additionalData]; |
ValeraS
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1246
Stand
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Bundle Size: ✅
Current: 79.10 MB | Main: 79.10 MB
Diff: +0.00 MB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information